Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: remove workarounds for lean4#1891 #9290

Closed
wants to merge 1 commit into from

Conversation

dwrensha
Copy link
Member

We no longer need to explicitly specify the Monotone and StrictMono arguments, after leanprover/lean4@069873d fixed leanprover/lean4#1891.

Compare to the mathlib3 declarations:
https://github.com/leanprover-community/mathlib/blob/65a1391a0106c9204fe45bc73a039f056558cb83/src/data/prod/lex.lean#L93-L107


Open in Gitpod

@dwrensha dwrensha added the awaiting-review The author would like community review of the PR label Dec 26, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 26, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 26, 2023
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 26, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove workarounds for lean4#1891 [Merged by Bors] - chore: remove workarounds for lean4#1891 Dec 26, 2023
@mathlib-bors mathlib-bors bot closed this Dec 26, 2023
@mathlib-bors mathlib-bors bot deleted the lean4-1891-fixed branch December 26, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CoeFun causes types to be unfolded
3 participants