Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: deduplicate LinearIndependent.set_finite_of_isNoetherian #9300

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - chore: deduplicate LinearIndependent.set_finite_of_isNoetherian #9300

wants to merge 7 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Dec 27, 2023 •
edited

Also moved several lemmas into Mathlib/LinearAlgebra/Basis.lean.

Open in Gitpod

@erdOne erdOne changed the title feat: deduplicate LinearIndependent.set_finite_of_isNoetherian chore: deduplicate LinearIndependent.set_finite_of_isNoetherian Dec 27, 2023
@erdOne erdOne added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Dec 27, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 27, 2023
@alreadydone alreadydone mentioned this pull request Dec 27, 2023
Closed
1 task
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 28, 2023
jcommelin
jcommelin approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 30, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 30, 2023
@erdOne
chore: deduplicate LinearIndependent.set_finite_of_isNoetherian (#9300
7392ea7 
)

Also moved several lemmas into `Mathlib/LinearAlgebra/Basis.lean`.



Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 30, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: deduplicate LinearIndependent.set_finite_of_isNoetherian [Merged by Bors] - chore: deduplicate LinearIndependent.set_finite_of_isNoetherian Dec 30, 2023
@mathlib-bors mathlib-bors bot closed this Dec 30, 2023
@mathlib-bors mathlib-bors bot deleted the erd1/setfiniteNoetherian branch December 30, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alreadydone alreadydone alreadydone left review comments

@riccardobrasca riccardobrasca riccardobrasca left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@erdOne @alreadydone @jcommelin @riccardobrasca @leanprover-community-mathlib4-bot