[Merged by Bors] - chore: mark neg_div_neg_eq as simp #9332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alexjbest
commented
Dec 29, 2023
alexjbest
commented
alexjbest
added
awaiting-review
jcommelin
reviewed
Jan 8, 2024
| @@ -100,9 +100,11 @@ theorem jacobiTheta_S_smul (τ : ℍ) : | |||
| rw [mul_comm ((1 : ℂ) / _) _, mul_one_div, eq_div_iff ha', mul_comm _ (_ ^ _), eq_comm] at this | |||
| have expo1 : ∀ n : ℤ, -↑π / (-I * ↑τ) * (n : ℂ) ^ 2 = ↑π * I * (n : ℂ) ^ 2 * (-↑τ)⁻¹ := by | |||
| intro n | |||
| field_simp [hτ, I_ne_zero] | |||
| simp only [neg_mul, neg_div_neg_eq, div_mul_eq_mul_div, inv_eq_one_div, mul_div_assoc', mul_one, | |||
There was a problem hiding this comment.
Should this be viewed as a regression? Or is there an explanation why this simp only is morally the better proof?
There was a problem hiding this comment.
Before it was nonterminal so liable to break
There was a problem hiding this comment.
But I'm not sure we have a field simp only
|
✌️ alexjbest can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
|
bors r+ |
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.