Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Data/Fintype/Fin): golf a proof #9336

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(Data/Fintype/Fin): golf a proof #9336

wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 29, 2023

We already have it for Set.range.

Open in Gitpod

@urkud
chore(Data/Fintype/Fin): golf a proof
3d657f6 
We already have it for `Set.range`.
@urkud urkud added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Dec 29, 2023
YaelDillies
YaelDillies reviewed Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this golf not work for the next two lemmas?

@urkud
Copy link
Member Author

urkud commented Dec 29, 2023

Does this golf not work for the next two lemmas?

The next one: yes; the one after the next one: no, because Data/Fin/Basic doesn't import Data/Set/Intervals/Basic, so we have no lemmas about Fin and Set.Ixx.

@robertylewis
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 30, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 30, 2023
@urkud
chore(Data/Fintype/Fin): golf a proof (#9336)
b060d4a 
We already have it for `Set.range`.
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 30, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data/Fintype/Fin): golf a proof [Merged by Bors] - chore(Data/Fintype/Fin): golf a proof Dec 30, 2023
@mathlib-bors mathlib-bors bot closed this Dec 30, 2023
@mathlib-bors mathlib-bors bot deleted the YK-golf-fin branch December 30, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaelDillies YaelDillies YaelDillies left review comments

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @robertylewis @YaelDillies