Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: Reorganize results about rank and finrank. #9349

Closed
wants to merge 27 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Dec 30, 2023

The files Mathlib.LinearAlgebra.FreeModule.Rank, Mathlib.LinearAlgebra.FreeModule.Finite.Rank, Mathlib.LinearAlgebra.Dimension and Mathlib.LinearAlgebra.Finrank were reorganized into a
folder Mathlib.LinearAlgebra.Dimension, containing the following files

  • Basic.lean: Contains the definition of Module.rank.
  • Finrank.lean: Contains the definition of FiniteDimensional.finrank.
  • StrongRankCondition.lean: Contains results about rank and finrank
    over rings satisfying strong rank condition
  • Free.lean: Contains results about rank and finrank of free modules
  • Finite.lean: Contains conditions or consequences for rank to be finite or zero
  • Constructions.lean: Contains the calculation of the rank of various constructions.
  • DivisionRing.lean: Contains results about rank and finrank of spaces over division rings.
  • LinearMap.lean: Contains results about LinearMap.rank

API changes:
IsNoetherian.rank_lt_aleph0 and FiniteDimensional.rank_lt_aleph0 are replaced with
rank_lt_aleph0.
Module.Free.finite_basis was renamed to Module.Finite.finite_basis.
FiniteDimensional.finrank_eq_rank was renamed to finrank_eq_rank.
rank_eq_cardinal_basis and rank_eq_cardinal_basis' were removed
in favour of Basis.mk_eq_mk and Basis.mk_eq_mk''.


Open in Gitpod

@alreadydone alreadydone added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Dec 31, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this effort 🎉

Two minor comments.

bors d+

Mathlib/LinearAlgebra/Dimension/Basic.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Dimension/Finite.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 1, 2024

✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Jan 1, 2024
@erdOne erdOne added auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. and removed auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. labels Jan 1, 2024
@erdOne
Copy link
Member Author

erdOne commented Jan 1, 2024

bors merge

@mathlib-bors
Copy link

mathlib-bors bot commented Jan 1, 2024

Canceled.

@erdOne
Copy link
Member Author

erdOne commented Jan 1, 2024

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jan 1, 2024
The files `Mathlib.LinearAlgebra.FreeModule.Rank`, `Mathlib.LinearAlgebra.FreeModule.Finite.Rank`, `Mathlib.LinearAlgebra.Dimension` and `Mathlib.LinearAlgebra.Finrank` were reorganized into a
folder `Mathlib.LinearAlgebra.Dimension`, containing the following files
- `Basic.lean`: Contains the definition of `Module.rank`.
- `Finrank.lean`: Contains the definition of `FiniteDimensional.finrank`.
- `StrongRankCondition.lean`: Contains results about `rank` and `finrank`
      over rings satisfying strong rank condition
- `Free.lean`: Contains results about `rank` and `finrank` of free modules
- `Finite.lean`: Contains conditions or consequences for `rank` to be finite or zero
- `Constructions.lean`: Contains the calculation of the `rank` of various constructions.
- `DivisionRing.lean`: Contains results about `rank` and `finrank` of spaces over division rings.
- `LinearMap.lean`: Contains results about `LinearMap.rank`

API changes:
`IsNoetherian.rank_lt_aleph0` and `FiniteDimensional.rank_lt_aleph0` are replaced with
`rank_lt_aleph0`.
`Module.Free.finite_basis` was renamed to `Module.Finite.finite_basis`.
`FiniteDimensional.finrank_eq_rank` was renamed to `finrank_eq_rank`.
`rank_eq_cardinal_basis` and `rank_eq_cardinal_basis'` were removed 
in favour of `Basis.mk_eq_mk` and `Basis.mk_eq_mk''`.



Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 1, 2024

Pull request successfully merged into master.

Build succeeded!

And happy new year! 🎉

@mathlib-bors mathlib-bors bot changed the title chore: Reorganize results about rank and finrank. [Merged by Bors] - chore: Reorganize results about rank and finrank. Jan 1, 2024
@mathlib-bors mathlib-bors bot closed this Jan 1, 2024
@mathlib-bors mathlib-bors bot deleted the erd1/refactorDimension branch January 1, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants