Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Mathlib/Algebra/Ring/Basic): Subsingleton, NoZeroDivisors and IsDomain #9407

Closed
wants to merge 7 commits into from

Conversation

XavierXarles
Copy link
Collaborator

XavierXarles and others added 3 commits January 3, 2024 13:03
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Mathlib/Algebra/Ring/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Ring/Basic.lean Outdated Show resolved Hide resolved
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a few more variants

maintainer merge

Copy link

github-actions bot commented Jan 5, 2024

🚀 Pull request has been placed on the maintainer queue by eric-wieser.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 5, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 5, 2024
…Domain (#9407)

Added some results relating NoZeroDivisors and IsDomain for Ring.



Co-authored-by: Xavier Xarles <56635243+XavierXarles@users.noreply.github.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 5, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Mathlib/Algebra/Ring/Basic): Subsingleton, NoZeroDivisors and IsDomain [Merged by Bors] - feat(Mathlib/Algebra/Ring/Basic): Subsingleton, NoZeroDivisors and IsDomain Jan 5, 2024
@mathlib-bors mathlib-bors bot closed this Jan 5, 2024
@mathlib-bors mathlib-bors bot deleted the NoZeroDivisors branch January 5, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants