[Merged by Bors] - feat: polyrith tactic
#942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digama0
force-pushed
the
polyrith
branch
2 times, most recently
from
cb9c25c
to
5660838
Compare
semorrison
reviewed
Dec 14, 2022
Co-authored-by: Scott Morrison <scott@tqft.net>
|
I've merged master, imported |
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
The main functionality of `polyrith` is represented here: it contacts Sagemath to get the coefficients required to pass to linear_combination. TODO: * [x] fix docs & lint * [ ] fix tests * There are some auxiliary tactics used to construct test cases for `polyrith` and perform dry-run testing which does not require contacting sage in CI. Since the mock testing setup is not done yet, you can only test it for real right now, but I don't want to run that in CI for the same reason so currently all the tests are commented out. Most of them are still failing though because of things like a missing instance for `CommSemiring Rat` or the existence of the `Real` type entirely. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
polyrith tacticpolyrith tactic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main functionality of
polyrithis represented here: it contacts Sagemath to get the coefficients required to pass to linear_combination.TODO:
polyrithand perform dry-run testing which does not require contacting sage in CI.Since the mock testing setup is not done yet, you can only test it for real right now, but I don't want to run that in CI for the same reason so currently all the tests are commented out. Most of them are still failing though because of things like a missing instance for
CommSemiring Rator the existence of theRealtype entirely.