[Merged by Bors] - chore: bump std4 dependency #9426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
the
auto-merge-after-CI
semorrison
added
awaiting-review
eric-wieser
reviewed
Jan 4, 2024
| @@ -4,7 +4,7 @@ | |||
| [{"url": "https://github.com/leanprover/std4", | |||
| "type": "git", | |||
| "subDir": null, | |||
| "rev": "d8610e1bcb91c013c3d868821c0ef28bf693be07", | |||
There was a problem hiding this comment.
For reference: leanprover-community/batteries@d8610e1...0f6bc5b
eric-wieser
reviewed
Jan 4, 2024
Comment on lines
-43
to
-46
| /-- For every hypothesis `h : a ~ b` where a `@[symm]` lemma is available, | ||
| add a hypothesis `h_symm : b ~ a`. -/ | ||
| elab "symm_saturate" : tactic => liftMetaTactic1 fun g => g.symmSaturate | ||
|
|
There was a problem hiding this comment.
Has this been moved to Std, or just deleted? The Std commit log doesn't make any such move obvious.
There was a problem hiding this comment.
This is only used by solve_by_elim, and moved to Std as part of leanprover-community/batteries#447
There was a problem hiding this comment.
Ah sorry, I was foiled by "load diff" banners blocking my ability to Ctrl+F!
|
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
This is quite a substantial bump as `Nondet` / `backtrack` / `solve_by_elim` have all moved to Std. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite a substantial bump as
Nondet/backtrack/solve_by_elimhave all moved to Std.Infelicities:
Except.emojihas becomeprivatein Std, so for now I've just made several copies of it here, at each point of use. feat: make Except.emoji public batteries#506 makes it public again.MVarId.noteis now inStd.Tactic.SolveByElim, so we need to (otherwise unnecessarily) import that. chore: move MVarId.note batteries#507 fixes this.