Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(AlgebraicTopology/TopologicalSimplex): clean up, golf #9431

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - chore(AlgebraicTopology/TopologicalSimplex): clean up, golf #9431

wants to merge 6 commits into from

Conversation

jcommelin
Copy link
Member

@jcommelin jcommelin commented Jan 4, 2024 •
edited

Open in Gitpod

@jcommelin jcommelin added the awaiting-review The author would like community review of the PR label Jan 4, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jan 4, 2024
@jcommelin jcommelin removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jan 5, 2024
YaelDillies
YaelDillies approved these changes Jan 6, 2024
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@joelriou
Copy link
Collaborator

joelriou commented Jan 9, 2024

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 9, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 9, 2024
@jcommelin
chore(AlgebraicTopology/TopologicalSimplex): clean up, golf (#9431)
4fd6d05
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(AlgebraicTopology/TopologicalSimplex): clean up, golf [Merged by Bors] - chore(AlgebraicTopology/TopologicalSimplex): clean up, golf Jan 9, 2024
@mathlib-bors mathlib-bors bot closed this Jan 9, 2024
@mathlib-bors mathlib-bors bot deleted the top-simplex-cleanup branch January 9, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcommelin @joelriou @YaelDillies @leanprover-community-mathlib4-bot