[Merged by Bors] - feat: Generalizing some results from CommRing to CommSemiring #9512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify some local instances to solve a problem after the proposed changes in TensorProduct
XavierXarles
added
awaiting-review
XavierXarles
added
the
awaiting-review
|
Is this still a draft? |
No, it's not, sorry. |
|
!bench |
|
Hopefully this does not slow |
|
Here are the benchmark results for commit f9a53a5. Benchmark Metric Change
===============================================================
+ ~Mathlib.Algebra.Module.LocalizedModule instructions -4.4%
+ ~Mathlib.RingTheory.IsTensorProduct instructions -11.6% |
|
That's surprising! I guess that's a good sign |
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
|
+3% wall clock isn’t great. Might be an artifact. |
|
Here are the benchmark results for commit f9a53a5. Benchmark Metric Change
===============================================================
+ ~Mathlib.Algebra.Module.LocalizedModule instructions -4.4%
+ ~Mathlib.RingTheory.IsTensorProduct instructions -11.6% |
How one does this checking? |
leanprover-community-mathlib4-bot
added
ready-to-merge
|
Canceled. |
|
bors merge (The diff was showing changes from #9125 too) |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
Most of the changes are minor. Co-authored-by: Xavier Xarles <56635243+XavierXarles@users.noreply.github.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes are minor.