Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Geometry/Manifold): use dot notation for IsOpen lemmas more #9567

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(Geometry/Manifold): use dot notation for IsOpen lemmas more #9567

wants to merge 1 commit into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Jan 8, 2024

While at it, switch from refine' to refine (easy cases only) in the lines I'm touching anyway.

Let me call this "borderline easy"; it depends on your scrolling speed :-)

@grunweg grunweg added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. t-differential-geometry Manifolds etc labels Jan 8, 2024
jcommelin
jcommelin approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 9, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 9, 2024
@grunweg
chore(Geometry/Manifold): use dot notation for IsOpen lemmas more (#9567
c41fe72 
)

While at it, switch from refine' to refine (easy cases only) in the lines I'm touching anyway.
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Geometry/Manifold): use dot notation for IsOpen lemmas more [Merged by Bors] - chore(Geometry/Manifold): use dot notation for IsOpen lemmas more Jan 9, 2024
@mathlib-bors mathlib-bors bot closed this Jan 9, 2024
@mathlib-bors mathlib-bors bot deleted the MR-geometry-manifold-dotnotation branch January 9, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grunweg @jcommelin @leanprover-community-mathlib4-bot