Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Covby): rename Covby to CovBy #9578

Closed
wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 9, 2024

Rename

  • CovbyCovBy, WcovbyWCovBy
  • *covby**covBy*
  • wcovby.finset_valWCovBy.finset_val, wcovby.finset_coeWCovBy.finset_coe
  • Covby.is_coatomCovBy.isCoatom

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR t-order Order hierarchy labels Jan 9, 2024
@urkud urkud requested a review from YaelDillies January 9, 2024 06:32
@YaelDillies
Copy link
Collaborator

I understand the naming convention, but I can't help thinking this will hinder typing speed for no clear benefit.

@jcommelin
Copy link
Member

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 9, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 9, 2024
Rename

- `Covby` → `CovBy`, `Wcovby` → `WCovBy`
- `*covby*` → `*covBy*`
- `wcovby.finset_val` → `WCovBy.finset_val`, `wcovby.finset_coe` → `WCovBy.finset_coe`
- `Covby.is_coatom` → `CovBy.isCoatom`
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Covby): rename Covby to CovBy [Merged by Bors] - chore(Covby): rename Covby to CovBy Jan 9, 2024
@mathlib-bors mathlib-bors bot closed this Jan 9, 2024
@mathlib-bors mathlib-bors bot deleted the YK-covby-rename branch January 9, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-order Order hierarchy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants