Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: More WithBot lemmas #9580

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat: More WithBot lemmas #9580

wants to merge 1 commit into from

Conversation

YaelDillies
Copy link
Collaborator

This makes simp stronger on WithBot, for use in #9083.

Also reorder the relevant lemmas so that the WithTop and WithBot sections are more identical.

Open in Gitpod

@YaelDillies
feat: More WithBot lemmas
745402f 
This makes simp stronger on `WithBot`, for use in #9083.

Also reorder the relevant lemmas so that the `WithTop` and `WithBot` sections are more identical.
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Jan 9, 2024
@YaelDillies YaelDillies mentioned this pull request Jan 9, 2024
Closed
1 task
jcommelin
jcommelin approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 9, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 9, 2024
@YaelDillies
feat: More WithBot lemmas (#9580)
fb274b3 
This makes simp stronger on `WithBot`, for use in #9083.

Also reorder the relevant lemmas so that the `WithTop` and `WithBot` sections are more identical.
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: More WithBot lemmas [Merged by Bors] - feat: More WithBot lemmas Jan 9, 2024
@mathlib-bors mathlib-bors bot closed this Jan 9, 2024
@mathlib-bors mathlib-bors bot deleted the with_bot_one_ne_bot branch January 9, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaelDillies @jcommelin @leanprover-community-mathlib4-bot