[Merged by Bors] - chore: refactor of Algebra/Group/Defs to reduce imports #9606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
the
awaiting-review
|
Can you
Personally I'm wondering why you're trying to get rid of
|
Vierkantor
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Nice work!
For the benefit of future readers, could you also note the changes to Tactic.Basic in the PR description?
bors d=@YaelDillies
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
YaelDillies
reviewed
Jan 10, 2024
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Done. |
semorrison
added
the
awaiting-review
YaelDillies
reviewed
Jan 11, 2024
leanprover-community-mathlib4-bot
added
merge-conflict
semorrison
force-pushed
the
group_defs_refactor
branch
from
a901444
to
14bf968
Compare
leanprover-community-mathlib4-bot
removed
the
merge-conflict
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
We are not that far from the point that `Algebra/Group/Defs` depends on nothing significant besides `simps` and `to_additive`. This removes from `Mathlib.Algebra.Group.Defs` the dependencies on * `Mathlib.Tactic.Basic` (which is a grab-bag of random stuff) * `Mathlib.Init.Algebra.Classes` (which is ancient and half-baked) * `Mathlib.Logic.Function.Basic` (not particularly important, but it is barely used in this file) The goal is to avoid all unnecessary imports to set up the *definitions* of basic algebraic structures. We also separate out `Mathlib.Tactic.TypeStar` and `Mathlib.Tactic.Lemma` as prerequisites to `Mathlib.Tactic.Basic`, but which can be imported separately when the rest of `Mathlib.Tactic.Basic` is not needed. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
eric-wieser
reviewed
Mar 4, 2024
Comment on lines
+12
to
+25
| open Lean | ||
|
|
||
| /-- `lemma` means the same as `theorem`. It is used to denote "less important" theorems -/ | ||
| syntax (name := lemma) declModifiers | ||
| group("lemma " declId ppIndent(declSig) declVal Parser.Command.terminationSuffix) : command | ||
|
|
||
| /-- Implementation of the `lemma` command, by macro expansion to `theorem`. -/ | ||
| @[macro «lemma»] def expandLemma : Macro := fun stx => | ||
| -- FIXME: this should be a macro match, but terminationSuffix is not easy to bind correctly. | ||
| -- This implementation ensures that any future changes to `theorem` are reflected in `lemma` | ||
| let stx := stx.modifyArg 1 fun stx => | ||
| let stx := stx.modifyArg 0 (mkAtomFrom · "theorem" (canonical := true)) | ||
| stx.setKind ``Parser.Command.theorem | ||
| pure <| stx.setKind ``Parser.Command.declaration |
There was a problem hiding this comment.
@semorrison, was moving these declarations to the root namespace (instead of leaving them in Mathlib.Tactic) deliberate?
sgouezel
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not that far from the point that
Algebra/Group/Defsdepends on nothing significant besidessimpsandto_additive.This removes from
Mathlib.Algebra.Group.Defsthe dependencies onMathlib.Tactic.Basic(which is a grab-bag of random stuff)Mathlib.Init.Algebra.Classes(which is ancient and half-baked)Mathlib.Logic.Function.Basic(not particularly important, but it is barely used in this file)The goal is to avoid all unnecessary imports to set up the definitions of basic algebraic structures.
We also separate out
Mathlib.Tactic.TypeStarandMathlib.Tactic.Lemmaas prerequisites toMathlib.Tactic.Basic, but which can be imported separately when the rest ofMathlib.Tactic.Basicis not needed.