[Merged by Bors] - feat: a / c ≡ b / c [PMOD p]
#9619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From LeanAPAP
YaelDillies
added
awaiting-review
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
urkud
reviewed
Jan 22, 2024
| @@ -321,6 +321,10 @@ theorem int_cast_modEq_int_cast {a b z : ℤ} : a ≡ b [PMOD (z : α)] ↔ a | |||
| norm_cast | |||
| #align add_comm_group.int_cast_modeq_int_cast AddCommGroup.int_cast_modEq_int_cast | |||
|
|
|||
| @[simp, norm_cast] | |||
| lemma intCast_modEq_intCast' {a b : ℤ} {n : ℕ} : a ≡ b [PMOD (n : α)] ↔ a ≡ b [PMOD (n : ℤ)] := by | |||
There was a problem hiding this comment.
Why intCast, not int_cast? The previous lemma uses int_cast.
There was a problem hiding this comment.
It's one operation, so should be one atom. Let me fix the previous lemma.
There was a problem hiding this comment.
OTOH, we have Function.Involutive.list_map
There was a problem hiding this comment.
I don't think we should block this PR on a naming decision that mathlib isn't consistent about.
leanprover-community-mathlib4-bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
a / c ≡ b / c [PMOD p]a / c ≡ b / c [PMOD p]
atarnoam
pushed a commit
that referenced
this pull request
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix a few misported names.
From LeanAPAP