Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Analysis/Analytic/Meromorphic): more API for meromorphic functions #9621

Closed
wants to merge 3 commits into from

Conversation

loefflerd
Copy link
Collaborator

This PR adds "order of vanishing" for meromorphic functions, and some basic API for functions MeromorphicOn a set.


Open in Gitpod

@loefflerd loefflerd added awaiting-review The author would like community review of the PR t-analysis Analysis (normed *, calculus) labels Jan 10, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 31, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 5, 2024
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

AnalyticAt.unique_eventuallyEq_zpow_smul_nonzero ⟨g, hg_an, hg_ne, hg_eq⟩⟩

/-- Compatibility of notions of `order` for analytic and meromorphic functions. -/
lemma order_of_analyticAt {f : 𝕜 → E} {x : 𝕜} (hf : AnalyticAt 𝕜 f x) :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you change the name of the lemma and move it into the AnalyticAt namespace?

∃ (n : ℤ) (g : 𝕜 → E), AnalyticAt 𝕜 g x ∧ ∀ᶠ z in 𝓝[≠] x, f z = (z - x) ^ n • g z := by
constructor
· intro hf_m
rcases eq_or_ne hf_m.order ⊤ with ho | ho
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you really need to use the order for this? You could just start from the definition of a meromorphic function, and multiply by (z - x) ^ (-n).

MeromorphicOn f U :=
fun x hx ↦ (hf x hx).meromorphicAt

lemma meromorphicOn_id {U : Set 𝕜} : MeromorphicOn id U := fun x _ ↦ meromorphicAt_id x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new dot notation in Lean 4, this kind of lemma should be named MeromorphicOn.id. The reason is that, if you're proving that a function is MeromorphicOn, then Lean 4 will let you use .id for MeromorphicOn.id, and it turns out to be really convenient. Same thing below for const.

@mathlib-bors
Copy link

mathlib-bors bot commented Feb 6, 2024

✌️ loefflerd can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Feb 6, 2024
@loefflerd
Copy link
Collaborator Author

Many thanks @sgouezel for the review!

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 6, 2024
…ns (#9621)

This PR adds "order of vanishing" for meromorphic functions, and some basic API for functions `MeromorphicOn` a set.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 6, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Feb 6, 2024
…ns (#9621)

This PR adds "order of vanishing" for meromorphic functions, and some basic API for functions `MeromorphicOn` a set.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 6, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Analysis/Analytic/Meromorphic): more API for meromorphic functions [Merged by Bors] - feat(Analysis/Analytic/Meromorphic): more API for meromorphic functions Feb 6, 2024
@mathlib-bors mathlib-bors bot closed this Feb 6, 2024
@mathlib-bors mathlib-bors bot deleted the DL_meromorphic_order branch February 6, 2024 15:00
atarnoam pushed a commit that referenced this pull request Feb 9, 2024
…ns (#9621)

This PR adds "order of vanishing" for meromorphic functions, and some basic API for functions `MeromorphicOn` a set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants