[Merged by Bors] - perf (Abelian.Transfer): clean up a dsimp #9641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!bench |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mattrobball
added
easy
grunweg
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Two birds with one stone: addresses a porting nice, shorter and nicer - and presumably even faster 🎉
Assuming benchmarking is neutral or positive (let alone wildly positive), looks good to me. (But I'm not an expert.)
Thank you for doing this, please keep going!
|
Here are the benchmark results for commit 1fe2ebe.Found no runs to compare against. |
|
✌️ mattrobball can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
|
bors merge |
|
bors r- I should delete that |
|
Canceled. |
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
Cleaning up a `dsimp` improves performance. Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up a
dsimpimproves performance.