Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: subset of a charted space is open iff each image in charts is #9672

Closed
wants to merge 5 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Jan 11, 2024

From sphere-eversion; I just cleaned it up slightly and submitted it.


Open in Gitpod

@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes t-topology Topological spaces, uniform spaces, metric spaces, filters and removed awaiting-review labels Jan 11, 2024
@grunweg grunweg force-pushed the MR-sphere-eversion-charted-space branch from 254cd24 to 362d689 Compare January 12, 2024 09:22
@grunweg grunweg added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 12, 2024
@urkud
Copy link
Member

urkud commented Jan 16, 2024

Thank you! I renamed lemmas because they were in the _root_ namespace without chart in their names.
bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2024

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@grunweg
Copy link
Collaborator Author

grunweg commented Jan 16, 2024

That's even nicer than my version; thanks for the review and the golf!
bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jan 16, 2024
)

From sphere-eversion; I just cleaned it up slightly and submitted it.



Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2024

Build failed:

@urkud
Copy link
Member

urkud commented Jan 16, 2024

Looks like an issue with Internet connection.
bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 16, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 16, 2024
)

From sphere-eversion; I just cleaned it up slightly and submitted it.



Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2024

Build failed:

@grunweg
Copy link
Collaborator Author

grunweg commented Jan 16, 2024

bors r+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2024

Canceled.

@grunweg grunweg changed the title feat: subset of charted space is open iff each image in charts is feat: subset of a charted space is open iff each image in charts is Jan 16, 2024
@grunweg
Copy link
Collaborator Author

grunweg commented Jan 16, 2024

Let's try this again
bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jan 16, 2024
…9672)

From sphere-eversion; I just cleaned it up slightly and submitted it.



Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@jcommelin
Copy link
Member

bors r-

Can you please merge master. There might be some minor issues with this PR vs master...

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2024

Canceled.

@jcommelin
Copy link
Member

Sorry 🤦 wrong PR. Meant #9764

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jan 16, 2024
…9672)

From sphere-eversion; I just cleaned it up slightly and submitted it.



Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: subset of a charted space is open iff each image in charts is [Merged by Bors] - feat: subset of a charted space is open iff each image in charts is Jan 16, 2024
@mathlib-bors mathlib-bors bot closed this Jan 16, 2024
@mathlib-bors mathlib-bors bot deleted the MR-sphere-eversion-charted-space branch January 16, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants