[Merged by Bors] - feat(Algebra/Homology): the class of quasi-isomorphisms in the homotopy category #9686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 12, 2024
joelriou
added
the
awaiting-review
jcommelin
reviewed
Feb 8, 2024
| namespace HomotopyCategory | ||
|
|
||
| /-- The class of quasi-isomorphisms in the homotopy category. -/ | ||
| def qis : MorphismProperty (HomotopyCategory C c) := |
There was a problem hiding this comment.
I would prefer
Suggested change
| def qis : MorphismProperty (HomotopyCategory C c) := | |
| def quasiIso : MorphismProperty (HomotopyCategory C c) := |
Or do you think the length will quickly become annoying?
There was a problem hiding this comment.
Thanks for the suggestion. I do not think it will be annoying at all. I have made the change both for HomologicalComplex.quasiIso and HomotopyCategory.quasiIso.
jcommelin
added
awaiting-author
joelriou
removed
the
awaiting-author
joelriou
added
the
awaiting-review
leanprover-community-mathlib4-bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
…py category (#9686) This PR introduces the class of quasi-isomorphisms in the homotopy category of homological complexes.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
atarnoam
pushed a commit
that referenced
this pull request
Feb 9, 2024
…py category (#9686) This PR introduces the class of quasi-isomorphisms in the homotopy category of homological complexes.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
…py category (#9686) This PR introduces the class of quasi-isomorphisms in the homotopy category of homological complexes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the class of quasi-isomorphisms in the homotopy category of homological complexes.