Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: bump to get std4#63 (use Nat.cast in place of Int.ofNat) #972

Closed
wants to merge 5 commits into from

Conversation

semorrison
Copy link
Contributor

@semorrison semorrison commented Dec 13, 2022

This verifies that leanprover-community/batteries#63 will work in mathlib4.

Before merging this:

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 13, 2022
@semorrison semorrison added awaiting-review and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Dec 13, 2022
@semorrison semorrison changed the title chore: test that std4#63 will work chore: bump to get std4#63 (use Nat.cast in place of Int.ofNat) Dec 13, 2022
@semorrison
Copy link
Contributor Author

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Dec 13, 2022
bors bot pushed a commit that referenced this pull request Dec 13, 2022
This verifies that leanprover-community/batteries#63 will work in mathlib4.

Before merging this:
* [x] check that leanprover-community/batteries#63 has been merged
* [x] change `lakefile.lean` to point back to "main" for the std4 dependency
* [ ] we may want to golf the proofs where I have added `simp only [Int.ofNat_eq_coe]`, to combine these into the adjacent rw/simp.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Dec 13, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore: bump to get std4#63 (use Nat.cast in place of Int.ofNat) [Merged by Bors] - chore: bump to get std4#63 (use Nat.cast in place of Int.ofNat) Dec 13, 2022
@bors bors bot closed this Dec 13, 2022
@bors bors bot deleted the test_std_63 branch December 13, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant