Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: tidy various files #9728

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - chore: tidy various files #9728

wants to merge 4 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-review The author would like community review of the PR label Jan 13, 2024
j-loreaux
j-loreaux reviewed Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Mathlib/Algebra/Homology/HomotopyCategory/HomComplex.lean Outdated Show resolved Hide resolved
Mathlib/Analysis/Calculus/FDeriv/Analytic.lean Outdated Show resolved Hide resolved
Mathlib/Analysis/Calculus/FDeriv/Analytic.lean Outdated Show resolved Hide resolved
Mathlib/Analysis/Calculus/Monotone.lean Show resolved Hide resolved
Mathlib/Analysis/Calculus/Monotone.lean Show resolved Hide resolved
Mathlib/GroupTheory/MonoidLocalization.lean Show resolved Hide resolved
Mathlib/RingTheory/Localization/Module.lean Outdated Show resolved Hide resolved
@j-loreaux j-loreaux added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 15, 2024
Ruben-VandeVelde and others added 3 commits January 16, 2024 21:34
@Ruben-VandeVelde
add deprecated alias
95457c3
@Ruben-VandeVelde
review
e2a596b
@Ruben-VandeVelde @j-loreaux
Apply suggestions from code review
1aade3c 
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 16, 2024
@j-loreaux
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 17, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 17, 2024
@Ruben-VandeVelde
chore: tidy various files (#9728)
8b8554a
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 17, 2024

Build failed:

@j-loreaux
Copy link
Collaborator

Let's try again ...

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jan 17, 2024
@Ruben-VandeVelde
chore: tidy various files (#9728)
a94a9fd
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 17, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: tidy various files [Merged by Bors] - chore: tidy various files Jan 17, 2024
@mathlib-bors mathlib-bors bot closed this Jan 17, 2024
@mathlib-bors mathlib-bors bot deleted the various-tidy branch January 17, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-loreaux j-loreaux j-loreaux left review comments

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ruben-VandeVelde @j-loreaux