Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Fintype/Order): generalize Fintype to Finite in Directed lemmas #9754

Closed
wants to merge 5 commits into from

Conversation

alreadydone
Copy link
Contributor


Open in Gitpod

@alreadydone alreadydone added awaiting-review The author would like community review of the PR t-order Order hierarchy labels Jan 15, 2024
@alreadydone alreadydone changed the title chore(Fintype/Order): generalize Fintype to Finite Directed lemmas chore(Fintype/Order): generalize Fintype to Finite in Directed lemmas Jan 15, 2024
@alreadydone alreadydone added awaiting-CI and removed awaiting-review The author would like community review of the PR labels Jan 15, 2024
@alreadydone alreadydone added the awaiting-review The author would like community review of the PR label Jan 15, 2024
@j-loreaux
Copy link
Collaborator

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 15, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 15, 2024
…#9754)

Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 15, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jan 16, 2024
…#9754)

Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 16, 2024

Build failed (retrying...):

@mathlib-bors
Copy link

mathlib-bors bot commented Jan 16, 2024

Canceled.

@alreadydone
Copy link
Contributor Author

Thanks @Parcly-Taxel! Weird that CI didn't catch this. Did deprecation detection become more powerful on master? Anyway I'll now try merge again.

@alreadydone alreadydone added the auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. label Jan 16, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jan 16, 2024
…#9754)

Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Fintype/Order): generalize Fintype to Finite in Directed lemmas [Merged by Bors] - chore(Fintype/Order): generalize Fintype to Finite in Directed lemmas Jan 16, 2024
@mathlib-bors mathlib-bors bot closed this Jan 16, 2024
@mathlib-bors mathlib-bors bot deleted the Finite_Directed branch January 16, 2024 04:46
linesthatinterlace pushed a commit that referenced this pull request Jan 16, 2024
…#9754)

Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. ready-to-merge This PR has been sent to bors. t-order Order hierarchy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants