-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Fintype/Order): generalize Fintype to Finite in Directed lemmas #9754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alreadydone
commented
Jan 15, 2024
alreadydone
added
awaiting-review
The author would like community review of the PR
t-order
Order hierarchy
labels
Jan 15, 2024
alreadydone
changed the title
chore(Fintype/Order): generalize Fintype to Finite Directed lemmas
chore(Fintype/Order): generalize Fintype to Finite in Directed lemmas
Jan 15, 2024
alreadydone
added
awaiting-CI
and removed
awaiting-review
The author would like community review of the PR
labels
Jan 15, 2024
alreadydone
added
the
awaiting-review
The author would like community review of the PR
label
Jan 15, 2024
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
Jan 15, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 15, 2024
…#9754) Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
…#9754) Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Build failed (retrying...): |
Canceled. |
Thanks @Parcly-Taxel! Weird that CI didn't catch this. Did deprecation detection become more powerful on master? Anyway I'll now try merge again. |
alreadydone
added
the
auto-merge-after-CI
Please do not add manually. Requests for a bot to merge automatically once CI is done.
label
Jan 16, 2024
As this PR is labelled bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
…#9754) Co-authored-by: Junyan Xu <junyanxu.math@gmail.com> Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
chore(Fintype/Order): generalize Fintype to Finite in Directed lemmas
[Merged by Bors] - chore(Fintype/Order): generalize Fintype to Finite in Directed lemmas
Jan 16, 2024
linesthatinterlace
pushed a commit
that referenced
this pull request
Jan 16, 2024
…#9754) Co-authored-by: Junyan Xu <junyanxu.math@gmail.com> Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-merge-after-CI
Please do not add manually. Requests for a bot to merge automatically once CI is done.
ready-to-merge
This PR has been sent to bors.
t-order
Order hierarchy
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.