Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: injective continuous linear map with closed range is a continuous linear equivalence #9756

Closed
wants to merge 11 commits into from

Conversation

winstonyin
Copy link
Collaborator

@winstonyin winstonyin commented Jan 15, 2024

Added analogue of LinearEquiv.ofInjective but for ContinuousLinearEquiv on Banach spaces.

Added analogue of LinearMap.rangeRestrict but for ContinuousLinearMap.

Also I updated a docstring that had the old name of a theorem.


Open in Gitpod

@winstonyin winstonyin added the awaiting-review The author would like community review of the PR label Jan 15, 2024
Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throughout the library we have things like ContinuousLinearMap.codRestrict which allow us to restrict a morphism to an appropriate codomain, and also versions specific to the range of the morphism (e.g., LinearMap.rangeRestrict). However, ContinuousLinearMap.rangeRestrict seems to be missing.

  1. Can you add ContinuousLinearMap.rangeRestrict?
  2. Provide a lemma linking your new definition to it?

Mathlib/Analysis/NormedSpace/Banach.lean Outdated Show resolved Hide resolved
@j-loreaux j-loreaux added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 15, 2024
@winstonyin
Copy link
Collaborator Author

I added ContinuousLinearMap.rangeRestrict and a simp lemma from rangeEquiv to it. Thanks for the quick review.

@winstonyin winstonyin added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 16, 2024
Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Almost there. Please wait for CI after you make the edits before merging.

bors d+

Mathlib/Analysis/NormedSpace/Banach.lean Outdated Show resolved Hide resolved
Mathlib/Analysis/NormedSpace/Banach.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 16, 2024

✌️ winstonyin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@j-loreaux j-loreaux added delegated and removed awaiting-review The author would like community review of the PR labels Jan 16, 2024
@winstonyin winstonyin added the awaiting-review The author would like community review of the PR label Jan 17, 2024
@j-loreaux
Copy link
Collaborator

j-loreaux commented Jan 17, 2024

@winstonyin this is delegated, you can now merge it yourself. No need to mark it awaiting-review. I'll let you merge in case there is some reason you were waiting.

EDIT: oops I see why you waited.

@j-loreaux j-loreaux added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 17, 2024
@winstonyin winstonyin added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 17, 2024
@j-loreaux
Copy link
Collaborator

FYI: I renamed to equivRange because I realized it's actually that which we have in other places in the library (which makes more sense because the symbols literally occur in the order , then range). Sorry for miscommunicating before.

@j-loreaux j-loreaux removed the awaiting-review The author would like community review of the PR label Jan 17, 2024
@j-loreaux
Copy link
Collaborator

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 17, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 17, 2024
…us linear equivalence (#9756)

Added analogue of [LinearEquiv.ofInjective](https://leanprover-community.github.io/mathlib4_docs/Mathlib/LinearAlgebra/Basic.html#LinearEquiv.ofInjective) but for `ContinuousLinearEquiv` on Banach spaces.

Added analogue of [LinearMap.rangeRestrict](https://leanprover-community.github.io/mathlib4_docs/Mathlib/LinearAlgebra/Basic.html#LinearMap.rangeRestrict) but for `ContinuousLinearMap`.

Also I updated a docstring that had the old name of a theorem.



Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 17, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: injective continuous linear map with closed range is a continuous linear equivalence [Merged by Bors] - feat: injective continuous linear map with closed range is a continuous linear equivalence Jan 17, 2024
@mathlib-bors mathlib-bors bot closed this Jan 17, 2024
@mathlib-bors mathlib-bors bot deleted the ofInjectiveOfIsClosed branch January 17, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants