Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(Filter/Basic): add Filter.comap_injective #9774

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(Filter/Basic): add Filter.comap_injective #9774

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 16, 2024

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. t-topology Topological spaces, uniform spaces, metric spaces, filters t-order Order theory labels Jan 16, 2024
grunweg
grunweg approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use dot notation here? In any case, looks good to me.

@grunweg grunweg changed the title feat(Fitler/Basic): add Filter.comap_injective feat(Filter/Basic): add Filter.comap_injective Jan 16, 2024
Vierkantor
Vierkantor approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With or without dot notation looks fine to me. I'll leave the choice up to you.

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Jan 16, 2024

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Jan 16, 2024
@urkud
Copy link
Member Author

urkud commented Jan 16, 2024

It takes Surjective, returns Injective, so the dot notation name would be longer. Also, this name aligns with Filter.map_injective.
bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 16, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 16, 2024
@urkud
feat(Filter/Basic): add Filter.comap_injective (#9774)
c705f36
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Filter/Basic): add Filter.comap_injective [Merged by Bors] - feat(Filter/Basic): add Filter.comap_injective Jan 16, 2024
@mathlib-bors mathlib-bors bot closed this Jan 16, 2024
@mathlib-bors mathlib-bors bot deleted the YK-comap-inj branch January 16, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

@grunweg grunweg grunweg approved these changes

Assignees
No one assigned
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-order Order theory t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @Vierkantor @grunweg @leanprover-community-mathlib4-bot