Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(Topology/Support): add locallyFinite_mulSupport_iff #9779

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(Topology/Support): add locallyFinite_mulSupport_iff #9779

wants to merge 3 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Jan 16, 2024 •
edited

From sphere-eversion; I'm just upstreaming it.

@grunweg grunweg added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. t-topology Topological spaces, uniform spaces, metric spaces, filters labels Jan 16, 2024
@mergify Mergify
Copy link

mergify bot commented Jan 16, 2024

⚠️ The sha of the head commit of this PR conflicts with #9777. Mergify cannot evaluate rules on this PR. ⚠️

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-math-PR This PR depends on another PR to Mathlib label Jan 16, 2024
@grunweg
feat(Topology/Support): add locallyFinite_mulSupport_iff
129e8d5 
From sphere-eversion; I'm just upstreaming it.
@grunweg grunweg force-pushed the MR-sphere-eversion-topology-support2 branch from 04813f5 to 129e8d5 Compare January 16, 2024 12:32
@grunweg grunweg removed the blocked-by-math-PR This PR depends on another PR to Mathlib label Jan 16, 2024
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 16, 2024
@grunweg
Copy link
Collaborator Author

grunweg commented Jan 16, 2024

awaiting-review

@github-actions github-actions bot added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 16, 2024
@sgouezel
Copy link
Contributor

Can you merge master and fix the conflict?

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 16, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 16, 2024
@grunweg grunweg added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Jan 16, 2024
@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 18, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 18, 2024
@grunweg
feat(Topology/Support): add locallyFinite_mulSupport_iff (#9779)
b105bcd 
From sphere-eversion; I'm just upstreaming it.
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 18, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Topology/Support): add locallyFinite_mulSupport_iff [Merged by Bors] - feat(Topology/Support): add locallyFinite_mulSupport_iff Jan 18, 2024
@mathlib-bors mathlib-bors bot closed this Jan 18, 2024
@mathlib-bors mathlib-bors bot deleted the MR-sphere-eversion-topology-support2 branch January 18, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel left review comments

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grunweg @sgouezel @fpvandoorn @leanprover-community-mathlib4-bot