Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Finset/Image): fix a @[deprecated] tag #9789

Closed
wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 16, 2024

Since Finset.Nonempty.image_iff and Finset.nonempty_image
have different explicitness/implicitness of arguments,
@[deprecated] doesn't suggest using Finset.image_nonempty
without a hint.


Open in Gitpod

Since `Finset.Nonempty.image_iff` and `Finset.nonempty_image`
have different explicitness/implicitness of arguments,
`@[deprecated]` doesn't suggest using `Finset.image_nonempty`
without a hint.
@urkud urkud added awaiting-review The author would like community review of the PR t-logic Logic (model theory, set theory, etc) labels Jan 16, 2024
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 16, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 16, 2024
Since `Finset.Nonempty.image_iff` and `Finset.nonempty_image`
have different explicitness/implicitness of arguments,
`@[deprecated]` doesn't suggest using `Finset.image_nonempty`
without a hint.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Finset/Image): fix a @[deprecated] tag [Merged by Bors] - chore(Finset/Image): fix a @[deprecated] tag Jan 16, 2024
@mathlib-bors mathlib-bors bot closed this Jan 16, 2024
@mathlib-bors mathlib-bors bot deleted the YK-fix-depr branch January 16, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, set theory, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants