[Merged by Bors] - feat({Ring|Field}Theory/Adjoin): add various results on adjoin #9790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acmepjz
added
awaiting-review
11 tasks
acmepjz
added
awaiting-author
acmepjz
added
awaiting-review
alreadydone
reviewed
Jan 18, 2024
alreadydone
approved these changes
Jan 19, 2024
|
There are still a couple of comments to be taken into account, but then LGTM, thanks! bors d+ |
|
✌️ acmepjz can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 19, 2024
Main changes: - for intermediate fields: add `extendScalars_adjoin`, `restrictScalars_adjoin_of_algEquiv`, `sup_toSubalgebra_of_isAlgebraic`, `adjoin_toSubalgebra_of_isAlgebraic`, `adjoin_rank_le_of_isAlgebraic`, and golf `sup_toSubalgebra` - for subalgebras: add `adjoin_eq_span_of_eq_span`, `adjoin_eq_span_basis`, `restrictScalars_adjoin`, `restrictScalars_adjoin_of_algEquiv`, `adjoin_rank_le`
|
Build failed: |
alreadydone
added
the
auto-merge-after-CI
|
As this PR is labelled bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 19, 2024
Main changes: - for intermediate fields: add `extendScalars_adjoin`, `restrictScalars_adjoin_of_algEquiv`, `sup_toSubalgebra_of_isAlgebraic`, `adjoin_toSubalgebra_of_isAlgebraic`, `adjoin_rank_le_of_isAlgebraic`, and golf `sup_toSubalgebra` - for subalgebras: add `adjoin_eq_span_of_eq_span`, `adjoin_eq_span_basis`, `restrictScalars_adjoin`, `restrictScalars_adjoin_of_algEquiv`, `adjoin_rank_le` Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
extendScalars_adjoin,restrictScalars_adjoin_of_algEquiv,sup_toSubalgebra_of_isAlgebraic,adjoin_toSubalgebra_of_isAlgebraic,adjoin_rank_le_of_isAlgebraic, and golfsup_toSubalgebraadjoin_eq_span_of_eq_span,adjoin_eq_span_basis,restrictScalars_adjoin,restrictScalars_adjoin_of_algEquiv,adjoin_rank_le