[Merged by Bors] - chore(MetricSpace/HausdorffDistance): split in two #9809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted imports, so should build. Needs main module docstrings.
grunweg
added
awaiting-review
awaiting-CI
t-topology
1 task
leanprover-community-mathlib4-bot
added
the
merge-conflict
grunweg
force-pushed
the
MR-split-HausdorffDistance
branch
from
8ac1725
to
bf679b2
Compare
grunweg
removed
the
merge-conflict
grunweg
commented
Jan 19, 2024
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
added
merge-conflict
leanprover-community-mathlib4-bot
added
merge-conflict
|
Can you explain what the two new files contain in the PR description? |
|
Merged master, and extended the PR description. |
grunweg
removed
the
merge-conflict
YaelDillies
reviewed
Feb 2, 2024
|
@YaelDillies Makes sense, I have moved the files as you suggested. (Despite the force-push, only the last three commits are new.) |
grunweg
force-pushed
the
MR-split-HausdorffDistance
branch
from
bfd3a64
to
888a360
Compare
YaelDillies
reviewed
Feb 6, 2024
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Thank you for the review. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
The file was becoming a bit large (1550 lines). Split in two files of about 900 and 700 lines: the first file contains more basic material, the second file contains all material related to thickenings. Extend the module docstrings by mentioning the main results in this file.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
atarnoam
pushed a commit
that referenced
this pull request
Feb 9, 2024
The file was becoming a bit large (1550 lines). Split in two files of about 900 and 700 lines: the first file contains more basic material, the second file contains all material related to thickenings. Extend the module docstrings by mentioning the main results in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file was becoming a bit large (1550 lines). Split in two files of about 900 and 700 lines:
the first file contains more basic material, the second file contains all material related to thickenings.
Extend the module docstrings by mentioning the main results in this file.
Feedback about the new docstrings is welcome; I wrote them from scratch.