[Merged by Bors] - feat(Analysis/Asymptotics/Asymptotics): generalize smul lemmas to normed rings #9811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
awaiting-review
|
Should we allow |
|
Possibly; though arguably with that change it should be renamed to |
|
Thanks! 🎉 |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
…med rings (#9811) Using `BoundedSMul` instead of `NormedSpace` makes these true more generally. The old proofs do not generalize, so are replaced with copies of the `mul` proofs. The `const_smul_self` lemmas match the existing `const_mul_self` ones.
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
…med rings (#9811) Using `BoundedSMul` instead of `NormedSpace` makes these true more generally. The old proofs do not generalize, so are replaced with copies of the `mul` proofs. The `const_smul_self` lemmas match the existing `const_mul_self` ones.
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
…med rings (#9811) Using `BoundedSMul` instead of `NormedSpace` makes these true more generally. The old proofs do not generalize, so are replaced with copies of the `mul` proofs. The `const_smul_self` lemmas match the existing `const_mul_self` ones.
|
Build failed (retrying...): |
|
This might be causing bors failure... bors r- bors d+ |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Canceled. |
1 task
|
bors merge |
|
It has a merge conflict now. Please merge |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Canceled. |
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 14, 2024
…med rings (#9811) Using `BoundedSMul` instead of `NormedSpace` makes these true more generally. The old proofs do not generalize, so are replaced with copies of the `mul` proofs. The `const_smul_self` lemmas match the existing `const_mul_self` ones. `shake` then reports that the imports can be reduced.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
riccardobrasca
pushed a commit
that referenced
this pull request
Feb 18, 2024
…med rings (#9811) Using `BoundedSMul` instead of `NormedSpace` makes these true more generally. The old proofs do not generalize, so are replaced with copies of the `mul` proofs. The `const_smul_self` lemmas match the existing `const_mul_self` ones. `shake` then reports that the imports can be reduced.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
…med rings (#9811) Using `BoundedSMul` instead of `NormedSpace` makes these true more generally. The old proofs do not generalize, so are replaced with copies of the `mul` proofs. The `const_smul_self` lemmas match the existing `const_mul_self` ones. `shake` then reports that the imports can be reduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
BoundedSMulinstead ofNormedSpacemakes these true more generally. The old proofs do not generalize, so are replaced with copies of themulproofs.The
const_smul_selflemmas match the existingconst_mul_selfones.shakethen reports that the imports can be reduced.