Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(*): reduce dependencies on Mathlib.Tactic.* #9816

Closed
wants to merge 4 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 17, 2024

  • Drop import Mathlib.Tactic.Basic in Mathlib.Init.Logic and Mathlib.Logic.Basic.
  • Fix compile, sometimes golf broken proofs instead of re-adding imports.

I have no particular reason for removing these edges in the import tree
other than "we can do this; why not?"

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI t-logic Logic (model theory, set theory, etc) labels Jan 17, 2024
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 18, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 18, 2024
- Drop `import Mathlib.Tactic.Basic` in `Mathlib.Init.Logic` and `Mathlib.Logic.Basic`.
- Fix compile, sometimes golf broken proofs instead of re-adding `import`s.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 18, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(*): reduce dependencies on Mathlib.Tactic.* [Merged by Bors] - chore(*): reduce dependencies on Mathlib.Tactic.* Jan 18, 2024
@mathlib-bors mathlib-bors bot closed this Jan 18, 2024
@mathlib-bors mathlib-bors bot deleted the YK-tactic-shake branch January 18, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, set theory, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants