Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: scope symmDiff notations #9844

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore: scope symmDiff notations #9844

wants to merge 2 commits into from

Conversation

PatrickMassot
Copy link
Member

@PatrickMassot PatrickMassot commented Jan 19, 2024 •
edited

Those notations are not scoped whereas the file is very low in the import hierarchy.

Open in Gitpod

@PatrickMassot PatrickMassot added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI labels Jan 19, 2024
sgouezel
sgouezel reviewed Jan 19, 2024
View reviewed changes
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Mathlib/Order/SymmDiff.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 19, 2024

✌️ PatrickMassot can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Jan 19, 2024
YaelDillies
YaelDillies reviewed Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you scope that in Order instead?

@PatrickMassot @sgouezel
Update Mathlib/Order/SymmDiff.lean
c401a10 
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@PatrickMassot
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 19, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 19, 2024
@PatrickMassot
chore: scope symmDiff notations (#9844)
5a29486
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 19, 2024

Build failed:

  • Build

@YaelDillies
Copy link
Collaborator

Also please include motivation for this change. This PR is currently unjustified for someone coming across it on GitHub.

@PatrickMassot
Copy link
Member Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jan 19, 2024
@PatrickMassot
chore: scope symmDiff notations (#9844)
99f0812 
Those notations are not scoped whereas the file is very low in the import hierarchy.
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 19, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: scope symmDiff notations [Merged by Bors] - chore: scope symmDiff notations Jan 19, 2024
@mathlib-bors mathlib-bors bot closed this Jan 19, 2024
@mathlib-bors mathlib-bors bot deleted the pm_scope_symmdiff branch January 19, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel left review comments

@YaelDillies YaelDillies YaelDillies left review comments

Assignees
No one assigned
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PatrickMassot @YaelDillies @sgouezel @leanprover-community-mathlib4-bot