New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: HahnSeries smul order inequality #9848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottCarnahan
added
the
awaiting-review
The author would like community review of the PR
label
Jan 19, 2024
urkud
reviewed
Jan 26, 2024
urkud
reviewed
Jan 26, 2024
urkud
added
awaiting-author
A reviewer has asked the author a question or requested changes
t-algebra
Algebra (groups, rings, fields etc)
t-order
Order hierarchy
and removed
awaiting-review
The author would like community review of the PR
labels
Jan 26, 2024
ScottCarnahan
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Jan 27, 2024
urkud
reviewed
Jan 29, 2024
urkud
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Jan 29, 2024
ScottCarnahan
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Jan 30, 2024
urkud
reviewed
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor cleanup, otherwise LGTM.
urkud
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Feb 5, 2024
ScottCarnahan
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Feb 6, 2024
urkud
reviewed
Feb 6, 2024
✌️ ScottCarnahan can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
Given a Hahn series `x` and a scalar `r` such that `r • x ≠ 0`, the order of `r • x` is not strictly less than the order of `x`. If the exponent poset is linearly ordered, the order of `x` is less than or equal to the order of `r • x`. (Note that the order of a Hahn series is not uniquely defined when the exponent poset is not linearly ordered.) This is a complement to the addition result `HahnSeries.min_order_le_order_add`.
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
feat: HahnSeries smul order inequality
[Merged by Bors] - feat: HahnSeries smul order inequality
Feb 6, 2024
atarnoam
pushed a commit
that referenced
this pull request
Feb 9, 2024
Given a Hahn series `x` and a scalar `r` such that `r • x ≠ 0`, the order of `r • x` is not strictly less than the order of `x`. If the exponent poset is linearly ordered, the order of `x` is less than or equal to the order of `r • x`. (Note that the order of a Hahn series is not uniquely defined when the exponent poset is not linearly ordered.) This is a complement to the addition result `HahnSeries.min_order_le_order_add`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting-review
The author would like community review of the PR
t-algebra
Algebra (groups, rings, fields etc)
t-order
Order hierarchy
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a Hahn series
x
and a scalarr
such thatr • x ≠ 0
, the order ofr • x
is not strictly less than the order ofx
. If the exponent poset is linearly ordered, the order ofx
is less than or equal to the order ofr • x
. (Note that the order of a Hahn series is not uniquely defined when the exponent poset is not linearly ordered.) This is a complement to the addition resultHahnSeries.min_order_le_order_add
.