Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: HahnSeries smul order inequality #9848

Closed
wants to merge 8 commits into from

Conversation

ScottCarnahan
Copy link
Collaborator

@ScottCarnahan ScottCarnahan commented Jan 19, 2024

Given a Hahn series x and a scalar r such that r • x ≠ 0, the order of r • x is not strictly less than the order of x. If the exponent poset is linearly ordered, the order of x is less than or equal to the order of r • x. (Note that the order of a Hahn series is not uniquely defined when the exponent poset is not linearly ordered.) This is a complement to the addition result HahnSeries.min_order_le_order_add.


Open in Gitpod

@ScottCarnahan ScottCarnahan added the awaiting-review The author would like community review of the PR label Jan 19, 2024
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy and removed awaiting-review The author would like community review of the PR labels Jan 26, 2024
@ScottCarnahan ScottCarnahan added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 27, 2024
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 29, 2024
@urkud urkud self-assigned this Jan 29, 2024
@ScottCarnahan ScottCarnahan added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 30, 2024
Copy link
Member

@urkud urkud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor cleanup, otherwise LGTM.

Mathlib/Algebra/SMulWithZero.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/SMulWithZero.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/HahnSeries.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/HahnSeries.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/HahnSeries.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/HahnSeries.lean Outdated Show resolved Hide resolved
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 5, 2024
@ScottCarnahan ScottCarnahan added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 6, 2024
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 6, 2024

✌️ ScottCarnahan can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@ScottCarnahan
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 6, 2024
Given a Hahn series `x` and a scalar `r` such that `r • x ≠ 0`, the order of `r • x` is not strictly less than the order of `x`.  If the exponent poset is linearly ordered, the order of `x` is less than or equal to the order of `r • x`.  (Note that the order of a Hahn series is not uniquely defined when the exponent poset is not linearly ordered.) This is a complement to the addition result `HahnSeries.min_order_le_order_add`.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 6, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: HahnSeries smul order inequality [Merged by Bors] - feat: HahnSeries smul order inequality Feb 6, 2024
@mathlib-bors mathlib-bors bot closed this Feb 6, 2024
@mathlib-bors mathlib-bors bot deleted the ScottCarnahan/HahnSeries2 branch February 6, 2024 21:44
atarnoam pushed a commit that referenced this pull request Feb 9, 2024
Given a Hahn series `x` and a scalar `r` such that `r • x ≠ 0`, the order of `r • x` is not strictly less than the order of `x`.  If the exponent poset is linearly ordered, the order of `x` is less than or equal to the order of `r • x`.  (Note that the order of a Hahn series is not uniquely defined when the exponent poset is not linearly ordered.) This is a complement to the addition result `HahnSeries.min_order_le_order_add`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants