[Merged by Bors] - feat(Trigonometric): add Complex.tan_eq_zero_iff'
#9877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version assumes that the cosine is not zero.
urkud
added
awaiting-review
grunweg
approved these changes
Jan 21, 2024
sgouezel
reviewed
Jan 30, 2024
| iff this number is equal to `k * π / 2` for an integer `k`. | ||
|
|
||
| Note that this lemma takes into account that we use zero as the junk value for division by zero. | ||
| See also `Complex.tan_eq_zero_iff'`. -/ | ||
| theorem tan_eq_zero_iff {θ : ℂ} : tan θ = 0 ↔ ∃ k : ℤ, θ = k * π / 2 := by |
There was a problem hiding this comment.
Could you take this occasion to swap the right hand side to k * π / 2 = θ? Same thing in the next lemma.
There was a problem hiding this comment.
Done (for tangent, not for other trig functions).
sgouezel
added
awaiting-author
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
…y/mathlib4 into YK-tan-eq-zero
urkud
added
awaiting-review
|
bors r+ |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
This version assumes that the cosine is not zero.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Complex.tan_eq_zero_iff'Complex.tan_eq_zero_iff'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version assumes that the cosine is not zero.