Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(Topology/CompactOpen): add Tendsto.compCM etc #9882

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(Topology/CompactOpen): add Tendsto.compCM etc #9882

wants to merge 3 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 21, 2024

  • Use explicit (g : C(Y, Z)) argument instead of variable.
    This way only implicit arguments are not visible right there in the source.
  • Add dot-notation lemmas about composition of bundled continuous functions.

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR t-topology Topological spaces, uniform spaces, metric spaces, filters labels Jan 21, 2024
grunweg
grunweg reviewed Jan 21, 2024
View reviewed changes
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check the second half carefully; the first half is indeed precisely the tweak in the commit message.

sgouezel
sgouezel reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

Mathlib/Topology/CompactOpen.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 30, 2024

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Jan 30, 2024
@urkud @sgouezel
Update Mathlib/Topology/CompactOpen.lean
b5cbab0 
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@urkud
Copy link
Member Author

urkud commented Jan 30, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 30, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 30, 2024
@urkud
feat(Topology/CompactOpen): add Tendsto.compCM etc (#9882)
b660fcb 
* Use explicit `(g : C(Y, Z))` argument instead of `variable`.
  This way only implicit arguments are not visible right there in the source.
* Add dot-notation lemmas about composition of bundled continuous functions.
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 30, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Topology/CompactOpen): add Tendsto.compCM etc [Merged by Bors] - feat(Topology/CompactOpen): add Tendsto.compCM etc Jan 30, 2024
@mathlib-bors mathlib-bors bot closed this Jan 30, 2024
@mathlib-bors mathlib-bors bot deleted the YK-cont-compCM branch January 30, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grunweg grunweg grunweg left review comments

@sgouezel sgouezel sgouezel left review comments

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @grunweg @sgouezel @leanprover-community-mathlib4-bot