[Merged by Bors] - chore(FieldTheory/PolynomialGaloisGroup): move lemmas, reduce imports #9886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#dependencies: `Mathlib.FieldTheory.PolynomialGaloisGroup`: 1826->1323 `Mathlib.Analysis.Complex.Polynomial`: 1811->1826 I'm not sure if we should add a new file.
negiizhao
added
WIP
|
!bench |
|
Here are the benchmark results for commit b24c24a. Benchmark Metric Change
====================================================================
- ~Mathlib.Analysis.Complex.Polynomial instructions 478.5%
+ ~Mathlib.FieldTheory.AbelRuffini instructions -14.6%
+ ~Mathlib.FieldTheory.PolynomialGaloisGroup instructions -46.0%
- ~Mathlib.NumberTheory.NumberField.Embeddings instructions 9.2% |
negiizhao
added
awaiting-review
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
|
This makes sense to me. maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
leanprover-community-mathlib4-bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
…#9886) #dependencies: `Mathlib.FieldTheory.PolynomialGaloisGroup`: 1826->1323 `Mathlib.Analysis.Complex.Polynomial`: 1811->1826 This needed one small change to a moved proof because `conj` is not allowed as an identifier when the `ComplexConjugate` locale is open. Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
riccardobrasca
pushed a commit
that referenced
this pull request
Feb 18, 2024
…#9886) #dependencies: `Mathlib.FieldTheory.PolynomialGaloisGroup`: 1826->1323 `Mathlib.Analysis.Complex.Polynomial`: 1811->1826 This needed one small change to a moved proof because `conj` is not allowed as an identifier when the `ComplexConjugate` locale is open. Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
…#9886) #dependencies: `Mathlib.FieldTheory.PolynomialGaloisGroup`: 1826->1323 `Mathlib.Analysis.Complex.Polynomial`: 1811->1826 This needed one small change to a moved proof because `conj` is not allowed as an identifier when the `ComplexConjugate` locale is open. Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#dependencies:
Mathlib.FieldTheory.PolynomialGaloisGroup: 1826->1323Mathlib.Analysis.Complex.Polynomial: 1811->1826This needed one small change to a moved proof because
conjis not allowed as an identifier when theComplexConjugatelocale is open.I'm not sure if we should add a new file.