-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: implement rpow norm_num extension #9893
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
058f917
feat: implement zpow norm_num extension
dwrensha 4c065bb
hoist the haveI'
dwrensha ebd7dfa
hoist it even higher
dwrensha 55b4a02
better style for .isRat wildcard match
dwrensha c7ed7bc
feat: add rpow norm_num extension
dwrensha aa06159
remove the long expresion
eric-wieser 3a5c28a
fix Bertrand.lean
dwrensha 9661a15
golf Qqs
eric-wieser 0bc31f0
add an assertion that the function is what we think it is
dwrensha 344cc7a
add .check
dwrensha 3763c5c
inline some positivity/norm_num1
dwrensha 33546e9
inline e'
dwrensha f2dae88
Merge branch 'master' into norm-num-rpow-2
dwrensha 806af0c
another inlining
dwrensha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
/- | ||
Copyright (c) 2021 Mario Carneiro All rights reserved. | ||
Released under Apache 2.0 license as described in the file LICENSE. | ||
Authors: Mario Carneiro, David Renshaw | ||
-/ | ||
import Mathlib.Analysis.SpecialFunctions.Pow.Real | ||
|
||
example : (2 : ℝ) ^ (3 : ℝ) = 8 := by norm_num1 | ||
example : (1 : ℝ) ^ (20 : ℝ) = 1 := by norm_num1 | ||
example : (-2 : ℝ) ^ (3 : ℝ) = -8 := by norm_num1 | ||
example : (1/5 : ℝ) ^ (2 : ℝ) = 1/25 := by norm_num1 | ||
example : (-1/3 : ℝ) ^ (-3 : ℝ) = -27 := by norm_num1 | ||
example : (1/2 : ℝ) ^ (-3 : ℝ) = 8 := by norm_num1 | ||
example : (2 : ℝ) ^ (-3 : ℝ) = 1/8 := by norm_num1 | ||
example : (-2 : ℝ) ^ (-3 : ℝ) = -1/8 := by norm_num1 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really care either way, but I'm curious what the advantage of
haveI
vshave
is here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me too! I'm just copying what I see in other extensions.