Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: images of intervals under (↑) : ℕ → ℤ #9927

Closed
wants to merge 14 commits into from
Closed

[Merged by Bors] - feat: images of intervals under (↑) : ℕ → ℤ #9927

wants to merge 14 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 23, 2024 •
edited

Also generalize IsUpperSet.Ioi_subset and IsLowerSet.Iio_subset
from a PartialOrder to a Preorder.

Open in Gitpod

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jan 23, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jan 23, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@urkud urkud added awaiting-review The author would like community review of the PR t-order Order hierarchy labels Jan 23, 2024
sgouezel
sgouezel reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Mathlib/Data/Nat/Cast/ImageInt.lean Outdated Show resolved Hide resolved
Mathlib/Data/Nat/Cast/ImageInt.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 30, 2024

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Jan 30, 2024
@urkud
Copy link
Member Author

urkud commented Jan 30, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 30, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 30, 2024
@urkud
feat: images of intervals under (↑) : ℕ → ℤ (#9927)
ae98c3f 
Also generalize `IsUpperSet.Ioi_subset` and `IsLowerSet.Iio_subset`
from a `PartialOrder` to a `Preorder`.
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 30, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: images of intervals under (↑) : ℕ → ℤ [Merged by Bors] - feat: images of intervals under (↑) : ℕ → ℤ Jan 30, 2024
@mathlib-bors mathlib-bors bot closed this Jan 30, 2024
@mathlib-bors mathlib-bors bot deleted the YK-nat-int-range branch January 30, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel left review comments

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors. t-order Order hierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @leanprover-community-mathlib4-bot @sgouezel