[Merged by Bors] - fix: generalize DivisionRing.toOfScientific #9947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you can cast a rat to a type, then we probably want decimal notation to work there too
eric-wieser
added
awaiting-review
|
!bench |
|
Here are the benchmark results for commit 23f4bc0. |
|
I am wondering what's the status of this? Will it be approved? |
|
I think probably it just needs some reviewer time, perhaps from @thorimur or @semorrison, just in case there's a reason I'm not aware of that makes this a bad idea |
|
bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
If you can cast a rat to a type, then we probably want decimal notation to work there too. This has the benefit of making the instance computable even in cases where some parts of the division ring structure are not. It also means that this could apply to matrices of rational numbers, which are not a division ring, but could have a rat cast.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Vierkantor
pushed a commit
that referenced
this pull request
Feb 5, 2024
If you can cast a rat to a type, then we probably want decimal notation to work there too. This has the benefit of making the instance computable even in cases where some parts of the division ring structure are not. It also means that this could apply to matrices of rational numbers, which are not a division ring, but could have a rat cast.
atarnoam
pushed a commit
that referenced
this pull request
Feb 9, 2024
If you can cast a rat to a type, then we probably want decimal notation to work there too. This has the benefit of making the instance computable even in cases where some parts of the division ring structure are not. It also means that this could apply to matrices of rational numbers, which are not a division ring, but could have a rat cast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you can cast a rat to a type, then we probably want decimal notation to work there too.
This has the benefit of making the instance computable even in cases where some parts of the division ring structure are not.
It also means that this could apply to matrices of rational numbers, which are not a division ring, but could have a rat cast.