[Merged by Bors] - refactor(Data/Rat/NNRat): move module and algebra instances #9951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have the instances for `ℕ`, `ℤ`, and `ℚ` in this file, so adding `NNRat` doesn't feel that out of place.
eric-wieser
added
awaiting-author
leanprover-community-mathlib4-bot
added
blocked-by-other-PR
eric-wieser
commented
Jan 24, 2024
| @@ -3,9 +3,10 @@ Copyright (c) 2022 Yaël Dillies, Bhavik Mehta. All rights reserved. | |||
| Released under Apache 2.0 license as described in the file LICENSE. | |||
| Authors: Yaël Dillies, Bhavik Mehta | |||
| -/ | |||
| import Mathlib.Algebra.Algebra.Basic | |||
| import Mathlib.Algebra.Function.Indicator | |||
There was a problem hiding this comment.
Removing this would remove another 30 or so dependencies, but I'm declaring that a problem for a follow-up. I think further reduction probably entails splitting this file.
There was a problem hiding this comment.
Note that I already reduced the dependencies of Algebra.Function.Indicator by quite a lot because of this.
eric-wieser
added
awaiting-review
1 task
|
I just noticed that maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Only before this PR though, right? |
leanprover-community-mathlib4-bot
added
ready-to-merge
Actually, this spurious dependency was introduced in #9950. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
As with #9950, this is motivated by: * Getting `NNRat` closed to `norm_num` * Being able to put an `nnrat_cast` field in `DivisionSemiring`s This brings down the number of dependencies of `NNRat` by around 600.
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
As with #9950, this is motivated by: * Getting `NNRat` closed to `norm_num` * Being able to put an `nnrat_cast` field in `DivisionSemiring`s This brings down the number of dependencies of `NNRat` by around 600.
|
Build failed (retrying...):
|
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
As with #9950, this is motivated by: * Getting `NNRat` closed to `norm_num` * Being able to put an `nnrat_cast` field in `DivisionSemiring`s This brings down the number of dependencies of `NNRat` by around 600.
|
Build failed: |
leanprover-community-mathlib4-bot
added
blocked-by-other-PR
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
As with #9950, this is motivated by: * Getting `NNRat` closed to `norm_num` * Being able to put an `nnrat_cast` field in `DivisionSemiring`s This brings down the number of dependencies of `NNRat` by around 600.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with #9950, this is motivated by:
NNRatclosed tonorm_numnnrat_castfield inDivisionSemiringsThis brings down the number of dependencies of
NNRatby around 600.Archimedeaninstances toOrder/Archimedean#9950The graph is still a monster: