Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: clean up uses of Pi.smul_apply #9970

Closed
wants to merge 13 commits into from

Conversation

mattrobball
Copy link
Collaborator

@mattrobball mattrobball commented Jan 24, 2024

After #9949, Pi.smul_apply can be used in simp again. This PR cleans up some workarounds.


Open in Gitpod

@mattrobball mattrobball added the awaiting-review The author would like community review of the PR label Jan 24, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jan 24, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jan 24, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 24, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 24, 2024
@Ruben-VandeVelde
Copy link
Collaborator

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@sgouezel
Copy link
Contributor

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 12, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 12, 2024
After #9949, `Pi.smul_apply` can be used in `simp` again. This PR cleans up some workarounds.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 12, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: clean up uses of Pi.smul_apply [Merged by Bors] - chore: clean up uses of Pi.smul_apply Feb 12, 2024
@mathlib-bors mathlib-bors bot closed this Feb 12, 2024
@mathlib-bors mathlib-bors bot deleted the mrb/clean_up_smul_apply branch February 12, 2024 08:24
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
After #9949, `Pi.smul_apply` can be used in `simp` again. This PR cleans up some workarounds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants