Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: several results about Monoid.Exponent #9975

Closed
wants to merge 15 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator


Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-review The author would like community review of the PR label Jan 24, 2024
Mathlib/GroupTheory/Exponent.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Exponent.lean Show resolved Hide resolved
Mathlib/GroupTheory/Exponent.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Exponent.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Exponent.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Exponent.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Exponent.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Exponent.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Exponent.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Exponent.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Exponent.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Exponent.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Group/Commute/Defs.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Exponent.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Exponent.lean Outdated Show resolved Hide resolved
@urkud urkud added the t-algebra Algebra (groups, rings, fields etc) label Jan 29, 2024
Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaël is correct, I have provided the proofs. Please remove the extraneous hypothesis. Otherwise LGTM.

Mathlib/GroupTheory/Exponent.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Exponent.lean Outdated Show resolved Hide resolved
@j-loreaux j-loreaux added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 15, 2024
Mathlib/GroupTheory/Exponent.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Exponent.lean Outdated Show resolved Hide resolved
@Ruben-VandeVelde
Copy link
Collaborator Author

I've run leaff on this PR, though I don't fully trust the output:

+ added Monoid.exponent_pos.{u}
+ added Monoid.ExponentExists.isOfFinOrder.{u}
+ added AddMonoid.lcm_addOrderOf_eq_exponent.{u}
+ added AddMonoid.ExponentExists.exponent_pos.{u}
+ added AddMonoid.addOrderOf_le_exponent.{u}
+ added Monoid.exponent_dvd_iff_forall_pow_eq_one.{u}
+ added AddMonoid.exists_addOrderOf_eq_exponent.{u}
+ added AddMonoid.ExponentExists.isOfFinAddOrder.{u}
+ added Monoid.ExponentExists.orderOf_pos.{u}
+ added Monoid.ExponentExists.of_finite.{u}
+ added AddMonoid.exponent_dvd_of_forall_addOrderOf_dvd.{u}
+ added commMonoidOfExponentTwo.{u}
+ added Monoid.ExponentExists.exponent_ne_zero.{u}
+ added AddMonoid.ExponentExists.of_finite.{u}
+ added Group.exponent_dvd_nat_card.{u}
+ added AddMonoid.exponent_pos.{u}
+ added Monoid.exponent_dvd.{u}
+ added Monoid.orderOf_le_exponent.{u}
+ added Monoid.exponent_dvd_of_forall_orderOf_dvd.{u}
+ added Commute.of_orderOf_dvd_two.{u}
+ added AddMonoid.ExponentExists.exponent_ne_zero.{u}
+ added Group.exponent_dvd_card.{u}
+ added AddMonoid.exponent_ne_zero.{u}
+ added AddCommute.of_addOrderOf_dvd_two.{u}
+ added AddMonoid.ExponentExists.addOrderOf_pos.{u}
+ added addCommMonoidOfExponentTwo.{u}
+ added AddMonoid.exponent_dvd_iff_forall_nsmul_eq_zero.{u}
+ added Monoid.ExponentExists.exponent_pos.{u}
+ added AddMonoid.exponent_dvd.{u}
+ added Monoid.lcm_orderOf_eq_exponent.{u}
+ added Monoid.exists_orderOf_eq_exponent.{u}
+ added Monoid.exponent_ne_zero.{u}
! type changed for mul_not_mem_of_exponent_two
! type changed for mul_comm_of_exponent_two
! type changed for add_not_mem_of_addOrderOf_eq_two
! type changed for mul_not_mem_of_orderOf_eq_two
! type changed for inv_eq_self_of_exponent_two
! type changed for instCommGroupOfExponentTwo
! type changed for instAddCommGroupOfExponentTwo
! type changed for inv_eq_self_of_orderOf_eq_two
! type changed for add_comm_of_exponent_two
! type changed for neg_eq_self_of_addOrderOf_eq_two
! type changed for neg_eq_self_of_exponent_two
! type changed for orderOf_eq_two_iff
! type changed for add_not_mem_of_exponent_two
! type changed for addOrderOf_eq_two_iff
! type changed for AddMonoid.exponent_dvd_of_forall_nsmul_eq_zero
! type changed for Monoid.exponent_dvd_of_forall_pow_eq_one
+ attribute protected added to Monoid.ExponentExists.exponent_pos
+ attribute protected added to AddMonoid.ExponentExists.exponent_ne_zero
+ attribute reducible added to addCommMonoidOfExponentTwo
+ attribute reducible added to commMonoidOfExponentTwo
+ attribute protected added to AddMonoid.ExponentExists.exponent_pos
+ attribute protected added to Monoid.ExponentExists.exponent_ne_zero
! moved mul_not_mem_of_exponent_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved addOrderOf_eq_two_iff from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved add_not_mem_of_addOrderOf_eq_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved inv_eq_self_of_orderOf_eq_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved inv_eq_self_of_orderOf_eq_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved add_comm_of_exponent_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved add_comm_of_exponent_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved mul_comm_of_exponent_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved neg_eq_self_of_addOrderOf_eq_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved neg_eq_self_of_addOrderOf_eq_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved mul_not_mem_of_orderOf_eq_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved neg_eq_self_of_exponent_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved neg_eq_self_of_exponent_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved mul_not_mem_of_orderOf_eq_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved instCommGroupOfExponentTwo from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved instCommGroupOfExponentTwo from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved add_not_mem_of_exponent_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved add_not_mem_of_exponent_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved mul_comm_of_exponent_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved addOrderOf_eq_two_iff from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved inv_eq_self_of_exponent_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved orderOf_eq_two_iff from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved orderOf_eq_two_iff from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved inv_eq_self_of_exponent_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved add_not_mem_of_addOrderOf_eq_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved mul_not_mem_of_exponent_two from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved instAddCommGroupOfExponentTwo from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent
! moved instAddCommGroupOfExponentTwo from Mathlib.GroupTheory.SpecificGroups.KleinFour to Mathlib.GroupTheory.Exponent

@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 16, 2024
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@j-loreaux
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 17, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 17, 2024
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 17, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: several results about Monoid.Exponent [Merged by Bors] - feat: several results about Monoid.Exponent Feb 17, 2024
@mathlib-bors mathlib-bors bot closed this Feb 17, 2024
@mathlib-bors mathlib-bors bot deleted the wip-monoid-exponent branch February 17, 2024 04:32
riccardobrasca pushed a commit that referenced this pull request Feb 18, 2024
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants