[Merged by Bors] - feat(CategoryTheory/Limits): pushouts in the category of sets #9992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
joelriou
changed the title
joelriou
added
the
awaiting-review
urkud
reviewed
Jan 29, 2024
urkud
reviewed
Jan 29, 2024
|
I left a couple of trivial comments but I'm not assigning this PR to myself because I'm not an active user of the category theory part of the library. |
|
Thanks @urkud for your suggestions! |
jcommelin
reviewed
Feb 8, 2024
jcommelin
added
awaiting-author
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
|
Thanks @jcommelin for the suggestions which I have all applied. |
joelriou
added
awaiting-review
jcommelin
reviewed
Feb 9, 2024
| intro x y z hxy hyz | ||
| obtain _|⟨_, _, h⟩|s|_ := hxy | ||
| · exact hyz | ||
| · obtain z₁|z₂ := z |
There was a problem hiding this comment.
Can this step also be integrated into the rintro?
There was a problem hiding this comment.
Thanks for the suggestions! I have used rintro for the hxy variable, but not for z because this would create 8 goals instead of 7.
jcommelin
added
awaiting-author
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
joelriou
added
awaiting-review
leanprover-community-mathlib4-bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
This PR studies pushouts in the category of types. Specific properties of the pushout when one of the morphisms is injective are obtained. This PR partly removes the reference to the issue #5752 : the `HasPushouts (Type _)` instance can now be found automatically, but not `HasPullbacks`. Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
atarnoam
pushed a commit
that referenced
this pull request
Feb 10, 2024
This PR studies pushouts in the category of types. Specific properties of the pushout when one of the morphisms is injective are obtained. This PR partly removes the reference to the issue #5752 : the `HasPushouts (Type _)` instance can now be found automatically, but not `HasPullbacks`. Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
This PR studies pushouts in the category of types. Specific properties of the pushout when one of the morphisms is injective are obtained. This PR partly removes the reference to the issue #5752 : the `HasPushouts (Type _)` instance can now be found automatically, but not `HasPullbacks`. Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR studies pushouts in the category of types. Specific properties of the pushout when one of the morphisms is injective are obtained.
This PR partly removes the reference to the issue #5752 : the
HasPushouts (Type _)instance can now be found automatically, but notHasPullbacks.