Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hover info for cases h : ... #3084

Merged
merged 2 commits into from
Dec 21, 2023
Merged

fix: hover info for cases h : ... #3084

merged 2 commits into from
Dec 21, 2023

Conversation

digama0
Copy link
Collaborator

@digama0 digama0 commented Dec 17, 2023

This makes hover info, go to definition, etc work for the h in cases h : e. The implementation is similar to that used for the generalize h : e = x tactic.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 17, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Dec 17, 2023 •
edited
Loading

  • ❗ Mathlib CI can not be attempted yet, as the 'nightly-testing-2023-12-17' branch does not exist there yet. We will retry when you push more commits. It may be necessary to rebase onto 'nightly' tomorrow. (2023-12-17 09:11:23)
  • ❗ Mathlib CI will not be attempted unless you rebase your PR onto the 'nightly' branch. (2023-12-19 10:22:39)
  • 💥 Mathlib branch lean-pr-testing-3084 build failed against this PR. (2023-12-22 21:44:35) View Log
  • ❌ Mathlib branch lean-pr-testing-3084 built against this PR, but testing failed. (2023-12-22 23:03:13) View Log
  • ✅ Mathlib branch lean-pr-testing-3084 has successfully built against this PR. (2023-12-23 00:45:20) View Log

@semorrison semorrison added this pull request to the merge queue Dec 21, 2023
Merged via the queue into leanprover:master with commit d1a15de Dec 21, 2023
7 checks passed
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Dec 22, 2023
@digama0 digama0 deleted the cases_hover branch December 27, 2023 02:41
@digama0 digama0 mentioned this pull request Dec 29, 2023
Merged
semorrison added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 5, 2024
@semorrison
chore: adaptations for leanprover/lean4#3084
a85698d
@semorrison semorrison mentioned this pull request Jan 5, 2024
Closed
mathlib-bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jan 7, 2024
@semorrison
chore: adaptations for leanprover/lean4#3084 (#9452)
2c20845 
These are the changes required to adapt to @digama0's leanprover/lean4#3084. 

Co-authored-by: @digama0 



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kha Kha Kha left review comments

@semorrison semorrison Awaiting requested review from semorrison semorrison is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@digama0 @leanprover-community-mathlib4-bot @Kha @semorrison