Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: adaptations for leanprover/lean4#3084 #9452

Closed
wants to merge 7 commits into from

Conversation

semorrison
Copy link
Contributor

@semorrison semorrison commented Jan 5, 2024

These are the changes required to adapt to @digama0's leanprover/lean4#3084.

Co-authored-by: @digama0


I'm not actually sure yet who wrote these changes! Mario made these changes, I'm just moving them from nightly-testing back to a PR to bump/v4.6.0.

Open in Gitpod

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Jan 5, 2024
@digama0
Copy link
Member

digama0 commented Jan 5, 2024

(I wrote these changes, see https://leanprover.zulipchat.com/#narrow/stream/345428-mathlib-reviewers/topic/CI.20failure.20on.20the.20nightly-testing.20branch/near/409644519)

@semorrison
Copy link
Contributor Author

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 7, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 7, 2024
These are the changes required to adapt to @digama0's leanprover/lean4#3084. 

Co-authored-by: @digama0 



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 7, 2024

Pull request successfully merged into bump/v4.6.0.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: adaptations for leanprover/lean4#3084 [Merged by Bors] - chore: adaptations for leanprover/lean4#3084 Jan 7, 2024
@mathlib-bors mathlib-bors bot closed this Jan 7, 2024
@mathlib-bors mathlib-bors bot deleted the adaptations_3084 branch January 7, 2024 07:35
mathlib-bors bot pushed a commit that referenced this pull request Jan 7, 2024
This is the adapation PR for leanprover/lean4#3123. It will be merged to `bump/v4.6.0` *after* `#9452.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants