Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support idents in auto tactics #3328

Merged
merged 3 commits into from
May 3, 2024

Conversation

digama0
Copy link
Collaborator

@digama0 digama0 commented Feb 14, 2024

This is still experimental, but it implements identifier support in auto tactics "in the obvious way". It also converts quoteAutoTactic to generate Expr directly instead of going via syntax (this doesn't have any effect other than increasing compile cost AFAICT).

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 14, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Feb 14, 2024

Mathlib CI status (docs):

  • ❗ Std CI can not be attempted yet, as the nightly-testing-2024-02-14 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Std CI should run now. (2024-02-14 08:48:31)
  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 1d17c7df2beafbef0b480aa68d395b37db278732 --onto 806e41151b6eb645e4ed5a40915b94b99f933564. (2024-05-02 22:18:12)

@semorrison
Copy link
Collaborator

What's the status of this PR? It would be good to have a test showing the changed behaviour. It's clear there's enthusiasm for this one, so it would be nice to get in.

@digama0 digama0 marked this pull request as ready for review May 2, 2024 22:00
Copy link
Contributor

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@semorrison semorrison added this pull request to the merge queue May 3, 2024
Merged via the queue into leanprover:master with commit 00cf577 May 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants