feat: apply’s error message should show implicit arguments as needed #3926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luckily the necessary functionality already exists in the form of `addPPExplicitToExposeDiff`. Fixes #3232.
…to joachim/failed-to-unify
…to joachim/failed-to-unify
nomeata
changed the title
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 16, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 16, 2024
leanprover-community-mathlib4-bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 16, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 16, 2024
|
Probably #3929 is better. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 18, 2024
…3929) luckily the necessary functionality already exists in the form of `addPPExplicitToExposeDiff`. But it is not cheap, and we should not run this code when the error message isn’t shown, so we should do this lazily. We already had `MessageData.ofPPFormat` to assemble the error message lazily, but it was restricted to returning `FormatWithInfo`, a data type that doesn’t admit a nice API to compose more complex messages (like `Format` or `MessageData` has; an attempt to fix that is in #3926). Therefore we split the functionality of `.ofPPFormat` into `.ofFormatWithInfo` and `.ofLazy`, and use `.ofLazy` to compute the more complex error message of `apply`. Fixes #3232. --------- Co-authored-by: David Thrane Christiansen <david@davidchristiansen.dk> Co-authored-by: Wojciech Nawrocki <wjnawrocki@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
luckily the necessary functionality already exists in the form of
addPPExplicitToExposeDiff. But it is not cheap, and we should not run this codewhen the error message isn’t shown, so this used
.ofPPFormatto assemble the errormessage lazily.
Unfortunately,
.ofPPFormatandFormatWithInfohave quite limited APIs for now.This PR adds
FormatWithInfo.appendin a way that renumbers the keys in theFormatand the
infos.This also requires
RBMap.mapKeysMono, and I got distracted a bit by writing the voluminous but boring proofs required for that somewhat trivial operation.The lack of interpolation syntax for
FormatWithInfois also annoying. It would be reallynicer if one could “just” use
MessageDatain.ofPPFormatsomehow.Fixes #3232.