perf: issue at binop% and binrel% elaborators
#4085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
This issue was affecting several Mathlib files.
semorrison
force-pushed
the
perf_binop_binrel
branch
from
392b3ee
to
c7a8c9b
Compare
This was referenced May 7, 2024
|
At leanprover-community/mathlib4#12718, I benchmarked a working mathlib with a v4.8.0-rc1 with this commit cherry picked on top. Overall there is a -400B in instructions driven mainly by one file which was -800B. The issue there was the new |
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 7, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 7, 2024
leanprover-community-mathlib4-bot
added
the
breaks-mathlib
|
The new slow-downs are pretty severe in |
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 7, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 7, 2024
leanprover-community-mathlib4-bot
added
builds-mathlib
|
I got different speed center results from leanprover-community/mathlib4#12719 than @mattrobball got from leanprover-community/mathlib4#12718; mine are worse, with an overall +500B instructions... The difference probably comes down to exactly where they converge with the |
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 7, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 7, 2024
|
It's universes triggering the expensive |
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 7, 2024
Testing for leanprover/lean4#4085 exposed possible regressions typeclass synthesis which can be ameliorated using explicit universes. We do this and we add references to the issue #12737 tracking these changes.
|
Closing in favour of #4092. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 8, 2024
This issue was affecting several Mathlib files. @mattrobball @semorrison This is a different solution for the issue. The comment at `Extra.lean` describes the new solution and documents the new issues found with the previous one. closes #4085
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2024
This issue was affecting several Mathlib files. @mattrobball @semorrison This is a different solution for the issue. The comment at `Extra.lean` describes the new solution and documents the new issues found with the previous one. closes #4085 (cherry picked from commit 2a5ca00)
semorrison
pushed a commit
that referenced
this pull request
May 8, 2024
This issue was affecting several Mathlib files. @mattrobball @semorrison This is a different solution for the issue. The comment at `Extra.lean` describes the new solution and documents the new issues found with the previous one. closes #4085 (cherry picked from commit 2a5ca00)
apnelson1
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 12, 2024
Testing for leanprover/lean4#4085 exposed possible regressions typeclass synthesis which can be ameliorated using explicit universes. We do this and we add references to the issue #12737 tracking these changes.
callesonne
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 16, 2024
Testing for leanprover/lean4#4085 exposed possible regressions typeclass synthesis which can be ameliorated using explicit universes. We do this and we add references to the issue #12737 tracking these changes.
semorrison
pushed a commit
that referenced
this pull request
May 21, 2024
This issue was affecting several Mathlib files. @mattrobball @semorrison This is a different solution for the issue. The comment at `Extra.lean` describes the new solution and documents the new issues found with the previous one. closes #4085 (cherry picked from commit 2a5ca00)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was affecting several Mathlib files.
@mattrobball Found where the
[nonassignable]s were coming from. Thanks for helping to diagnose this performance issue.