perf: issue at binop% and binrel% elaborators
#4092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
leodemoura
force-pushed
the
perf_binop_binrel_alternative
branch
from
4ad4b5f
to
94bf4a8
Compare
Yet another candidate solution. This issue was affecting several Mathlib files.
leodemoura
force-pushed
the
perf_binop_binrel_alternative
branch
from
94bf4a8
to
932fb1c
Compare
|
Rebased on top of |
|
Mathlib master builds locally with this cherry-picked on top of v4.8.0-rc1 without any changes. Anecdotally, it seems quite snappy. |
|
leanprover-community/mathlib4#12742 has a benchmark run using the above. Overall -1.1T build instructions and no individual files suffered significant regressions but the wall clock was up +37%. I think the latter is anomaly. Will re-run. |
|
Wall clock was an anomaly. Last run was neutral. |
|
(The automatic Mathlib run didn't happen because of a CI breakage induced by the std -> batteries rename. Hopefully fixed going forward by leanprover-community/batteries#785.) |
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 8, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 8, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2024
This issue was affecting several Mathlib files. @mattrobball @semorrison This is a different solution for the issue. The comment at `Extra.lean` describes the new solution and documents the new issues found with the previous one. closes #4085 (cherry picked from commit 2a5ca00)
semorrison
pushed a commit
that referenced
this pull request
May 8, 2024
This issue was affecting several Mathlib files. @mattrobball @semorrison This is a different solution for the issue. The comment at `Extra.lean` describes the new solution and documents the new issues found with the previous one. closes #4085 (cherry picked from commit 2a5ca00)
leanprover-community-mathlib4-bot
added
the
builds-mathlib
semorrison
pushed a commit
that referenced
this pull request
May 21, 2024
This issue was affecting several Mathlib files. @mattrobball @semorrison This is a different solution for the issue. The comment at `Extra.lean` describes the new solution and documents the new issues found with the previous one. closes #4085 (cherry picked from commit 2a5ca00)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was affecting several Mathlib files.
@mattrobball @semorrison This is a different solution for the issue. The comment at
Extra.leandescribes the new solution and documents the new issues found with the previous one.closes #4085