perf: short-circuit lean_string_append #642
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!bench |
|
Here are the benchmark results for commit 5704009. Benchmark Metric Change
=====================================
- stdlib parsing 2% (72.9 σ) |
|
Huh, interesting |
|
!bench |
|
Here are the benchmark results for commit ce3b065. Benchmark Metric Change
======================================
- stdlib parsing 2% (368.8 σ) |
|
Oh well. |
|
Interesting benchmarks! I guess it is at least 8 additional instructions for every copy for an edge case that might not happen that often. Thus, the former may outweigh the later. |
ChrisHughes24
pushed a commit
to ChrisHughes24/lean4
that referenced
this pull request
Dec 2, 2022
Tracking mathlib commit: [fd47bdf09e90f553519c712378e651975fe8c829](leanprover-community/mathlib@fd47bdf) Co-authored-by: David Wärn <codwarn@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Scott Morrison <scott@tqft.net>
ChrisHughes24
pushed a commit
to ChrisHughes24/lean4
that referenced
this pull request
Dec 2, 2022
- [x] depends on: leanprover#642 - [x] depends on: leanprover-community/mathlib#17730 Tracking mathlib commit: [e50b8c261b0a000b806ec0e1356b41945eda61f7](leanprover-community/mathlib@e50b8c2) Co-authored-by: David Wärn <codwarn@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Scott Morrison <scott@tqft.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to allocate/copy when either side is the empty string