fix: ignore def/theorem confusion in docBlame
#269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some `def`s are generated by core and should really be theorems; we treat them as such in the `docBlame` and `docBlameThm` linters.
10 tasks
digama0
reviewed
Sep 21, 2023
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
|
test? |
|
There was already a test for |
digama0
reviewed
Sep 21, 2023
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
eric-wieser
commented
Sep 21, 2023
digama0
reviewed
Sep 21, 2023
|
|
|
Is there an issue for this on the lean4 repository? I can't find one. It would be good to link to such an issue from the code here, even it is linking to a |
|
I'm not aware of one. I'd prefer to get this merged soon, as the sooner this is merged the sooner we stop receiving useless comments like in mathlib |
|
I think you should open a tracking issue and link to it from this PR. |
semorrison
reviewed
Sep 23, 2023
semorrison
reviewed
Sep 23, 2023
semorrison
reviewed
Sep 23, 2023
semorrison
approved these changes
Sep 23, 2023
Co-authored-by: Scott Morrison <scott@tqft.net>
yuma-mizuno
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 5, 2023
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 18, 2024
Created by running `lake exe runLinter --update Mathlib` locally. Most changes are due to leanprover/std4#269: proof fields in classes or structures do not require a docstring any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
defs are generated by core and should really be theorems; we treat them as such in thedocBlameanddocBlameThmlinters.This fixes #217.